[solved] Warning from Minifier.php


#1

Hello,

I have this warning when i open the Multisite module :

WARNING: /www/piwik/vendor/tedivm/jshrink/src/JShrink/Minifier.php(243): Warning - "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? - Matomo 3.7.0

The warning will disappear if I replace “contiinue;” with “break;” on line 243.

Should I keep that “patch” ?


(Fabian Dellwing) #2

This warning will be fixed in Matomo 3.9.0 (update JShrink by Findus23 · Pull Request #13639 · matomo-org/matomo · GitHub).

Keeping break until then, should be fine.


#3

ok i’ll do that.

thank you for replying so quickly :slight_smile:


(Lukas Winkler) #4

Alternatively you can keep using PHP 7.2.

But this is just a warning in a library that shouldn’t break anything.