Missing ?>'s


#1

Hi,

I was using Piwik all the time but since I changed my server environment for developing (no XAMPP), I can’t run Piwik.
The reason is: A lot of Piwik’s php files don’t end with ?>, i.e. the corresponding end php tag. It is simply omitted. This may work on some apache configurations perhaps but it’s actually not correct php code.
For example in:
core/view/Interface.php
plugins/Proxy/Proxy.php
plugins/ExampleAPI/ExampleAPI.php
core/Version.php
libs/Zend/Session.php
[…]
I can’t correct anything in Piwik. The workload would be too high.

Well, then, probably Google Analytics is programmed correctly.


(vipsoft) #2

Missing the trailing ?>'s is intentional as it avoids “Headers already sent” when unseen newlines are added at the end of the file.

And it is valid PHP code. See PHP: Instruction separation - Manual