Logo for custom Browser/user-agent

rezeptpflichtig · March 5, 2019, 3:35pm

Hello,
I added a custom user agent with a custom logo that works almost everywhere (Browser Version/Visits Log/Visitor Profile) but not on the Browser Widget.
<tr data-segment-filter="browserCode==N1" data-row-metadata="{"logo":"plugins\/Morpheus\/icons\/dist\/browsers\/UNK.png","segment":"browserCode==N1"}" class=" ">
I just does not take the N1.png that gets displayed everywhere else but takes the UNK.png
I could not find the portion of the code that is responsible for that.
Is this the logo for the browser family? I already added a custom browser family into the device-detector but don’t know how to assign the logo to it. any idea?

regards

Lukas · March 5, 2019, 7:42pm

I can’t promise it, but I think browser families just use the icon of the first browser:

github.com

matomo-org/device-detector/blob/013b78618d81f4cfdbba979449d9ca27d9aab7ad/Parser/Client/Browser.php#L204


    'WT' => 'WeTab Browser',
    'YA' => 'Yandex Browser',
    'XI' => 'Xiino'
);


/**
 * Browser families mapped to the short codes of the associated browsers
 *
 * @var array
 */
protected static $browserFamilies = array(
    'Android Browser'    => array('AN', 'MU'),
    'BlackBerry Browser' => array('BB'),
    'Baidu'              => array('BD', 'BS'),
    'Amiga'              => array('AV', 'AW'),
    'Chrome'             => array('CH', 'BA', 'BR', 'CC', 'CD', 'CM', 'CI', 'CF', 'CN', 'CR', 'CP', 'IR', 'RM', 'AO', 'TS', 'VI', 'PT', 'AS', 'TB', 'AD'),
    'Firefox'            => array('FF', 'FE', 'FM', 'SX', 'FB', 'PX', 'MB', 'EI', 'WF', 'CU', 'TF', 'QM'),
    'Internet Explorer'  => array('IE', 'IM', 'PS'),
    'Konqueror'          => array('KO'),
    'NetFront'           => array('NF'),
    'NetSurf'            => array('NE'),

This is the code for the icons, so you should be able to find out more by printing the variables there:

github.com

matomo-org/matomo/blob/5076bd6bfdc32b969f122a5ef65c02fb1ab3c5b2/plugins/DevicesDetection/functions.php#L80-L112


function getBrowserLogo($short)
{
$path = 'plugins/Morpheus/icons/dist/browsers/%s.png';


// If name is given instead of short code, try to find matching shortcode
if (strlen($short) > 2) {


    if (in_array($short, BrowserParser::getAvailableBrowsers())) {
        $flippedBrowsers = array_flip(BrowserParser::getAvailableBrowsers());
        $short = $flippedBrowsers[$short];
    } else {
        $short = substr($short, 0, 2);
    }
}


$family = getBrowserFamilyFullName($short);


$browserFamilies = BrowserParser::getAvailableBrowserFamilies();


if (!empty($short) &&

This file has been truncated. show original

rezeptpflichtig · March 7, 2019, 2:11pm

thanks, that did help;
matomo capitalizes the browser names and the widget also uses that modified name to make an in_array lookup that fails and returns the UNK.png
I just changed my custom browsers to use that capitalized name in the Parser/Browser.php and in the yaml file to make it work.