Support for sockets still "kludgey"?

piwikrocks · February 27, 2012, 12:28am

Is support for sockets still kludgey as indicated in this 3-year-old bug:

github.com/matomo-org/matomo

MySQL: unix socket support

opened 02:29PM - 18 Mar 09 UTC

closed 04:13PM - 19 Mar 09 UTC

robocoder

Bug

Piwik support for unix sockets is kludgey. The unix socket is configured (embed…ded in) the host setting: ``` host = "localhost;unix_socket=/path" ``` This results in a DSN that looks like "host=localhost;unix_socket=/path;port=3306". For now, this appears to work, but according to PHP docs (http://www.php.net/manual/en/ref.pdo-mysql.connection.php), unix_socket "shouldn't be used with host or port" in the PDO DSN. (The implication is that while this works now, this may not be the case in the future.) In core/Tracker/Db.php, I propose: (I omit the drivername and dbname to simplify the pseudocode) ``` if (host[0] == '/') { dsn = "unix_socket=$host"; } else { dsn = "host=$host;port=$port"; } ```

It seems to be working fine but I wonder if I should use port 3306 directly instead. Does the advice in that bug still apply?

matthieu · February 27, 2012, 1:28am

ticket is closed so AFAIK it works fine

piwikrocks · February 27, 2012, 3:59pm

OK, thank you.