seb303
April 7, 2024, 2:30pm
9
In the end, it seemed cleaner to patch the actual Resolution (and DevicePixelRatio) plugins rather than creating another plugin to override the behaviour.
PRs submitted:
matomo-org:5.x-dev
← seb303:5.x-dev
opened 02:09PM - 07 Apr 24 UTC
Fixes the issue mentioned here:
https://github.com/matomo-org/matomo/issues/220… 79
Opted for suggestion (2):
If the resolution happens to be "unknown" in the first page impression of a visit, then when a specific value is available from a subsequent page impression, this value will replace the "unknown" value. For backwards compatibility, once a specific value is set, it will not be overridden by a different value from a subsequent page impression.
### Review
* [ ] [Functional review done](https://developer.matomo.org/guides/pull-request-reviews#functional-review-done)
* [ ] [Potential edge cases thought about](https://developer.matomo.org/guides/pull-request-reviews#potential-edge-cases-thought-about) (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
* [ ] [Usability review done](https://developer.matomo.org/guides/pull-request-reviews#usability-review-done) (is anything maybe unclear or think about anything that would cause people to reach out to support)
* [ ] [Security review done](https://developer.matomo.org/guides/security-in-piwik#checklist)
* [ ] [Wording review done](https://developer.matomo.org/guides/pull-request-reviews#translations-wording-review-done)
* [ ] [Code review done](https://developer.matomo.org/guides/pull-request-reviews#code-review-done)
* [ ] [Tests were added if useful/possible](https://developer.matomo.org/guides/pull-request-reviews#tests-were-added-if-usefulpossible)
* [ ] [Reviewed for breaking changes](https://developer.matomo.org/guides/pull-request-reviews#reviewed-for-breaking-changes)
* [ ] [Developer changelog updated if needed](https://developer.matomo.org/guides/pull-request-reviews#developer-changelog-updated-if-needed)
* [ ] [Documentation added if needed](https://developer.matomo.org/guides/pull-request-reviews#documentation-added-if-needed)
* [ ] Existing documentation updated if needed
johsin18:5.x-dev
← seb303:5.x-dev
opened 02:22PM - 07 Apr 24 UTC
Fix to address the issue mentioned here:
https://github.com/johsin18/DevicePixe… lRatioMatomoPlugin/issues/3
Have submitted a similar PR for the Matomo Core Resolution plugin.
https://github.com/matomo-org/matomo/pull/22080
1 Like