r4533 breaks GeoIP plugin (Piwik_Common::ip2long has been removed)

(blueyed) #1

Just wanted to notify you that the GeoIP plugin needs an update to use ip2long directly.
On the other hand, the Piwik_Common::ip2long method might get added back to provide backwards compatibility also?!

Removed in http://dev.piwik.org/trac/changeset/4533

(vipsoft) #2

Thanks. I’ll update the GeoIP plugin for the upcoming 1.4 release.

(vipsoft) #3

I think you meant long2ip.

I decided not to update the GeoIP plugin. Instead, I’ve added Piwik_Common::long2ip() for plugins that only expect IPv4 addresses.


(Matthieu Aubry) #4

your testing is very appeciated blueyed!!