New Funnel triggers past report generation

nelhefni · March 23, 2021, 1:11am

Hi,

There is currently a bug in the code preventing
rearchive_reports_in_past_last_n_months = last0
nor
rearchive_reports_in_past_last_n_months = 0
to work. Both fail, as explained here: Past Goal/Funnel report generation ends up in infinite loop

Anyway, even if this setting was working, past Funnel reports would still be generated, because last0 simply means the beginning of the current month.
Thus, if I update or create a Funnel today (March 23rd), all past reports since March 1st would be generated.
Indeed, there is a setDay(1) in the code, that will always set the start date to the first day of the month.

github.com

matomo-org/matomo/blob/34bf9d84c08f642c204e967acea55eb631ee6439/core/Archive/ArchiveInvalidator.php#L804


        $lastNMonthsToInvalidate = Config::getInstance()->General['rearchive_reports_in_past_last_n_months'];
        if (empty($lastNMonthsToInvalidate)) {
            return null;
        }
        $lastNMonthsToInvalidate = (int) substr($lastNMonthsToInvalidate, 4);
        if (empty($lastNMonthsToInvalidate)) {
            return null;
        }
        return Date::yesterday()->subMonth($lastNMonthsToInvalidate)->setDay(1);
    }
}